Improve application.properties textmate grammar #236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233
The PR textmate/ini.tmbundle#1 that fixes this apostrophe problem:
uses the
\K
regex pattern, which VS Code does not seem to support: microsoft/vscode#93426Therefore in VS Code, the regexes with
\K
in that PR does not match with anything, therefore does not highlight anything in orange, therefore appearing to solve the issue in VS Code.The PR I am making right now, contains TextMate grammar from https://github.com/microsoft/vscode/blob/master/extensions/ini/syntaxes/ini.tmLanguage.json, removes source ini specific grammar (like using
;
for commenting), removes matching the single or double quotes (which removes the orange string highlighting alltogether), and adds support for multi-line property keys and number highlighting.Examples:
Signed-off-by: David Kwon [email protected]