Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Pubnub to use SSL. #125

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Allow Pubnub to use SSL. #125

merged 1 commit into from
Jan 8, 2018

Conversation

bnazari
Copy link
Contributor

@bnazari bnazari commented Nov 30, 2017

Modify ruby settings to use SSL to allow PubNub to function.

https://www.pubnub.com/docs/ruby/api-reference-configuration

pubnub

Modify ruby settings to use SSL to allow PubNub to function.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 88.891% when pulling a0e413b on bnazari:patch-7 into 67c2d68 on redcross:master.

@cecilia-donnelly
Copy link

@bnazari can you expand this PR message a bit? What does PubNub do in the application? Can you point to some documentation of why it needs SSL? Thanks!

@pjsier
Copy link
Contributor

pjsier commented Dec 12, 2017

An update here, this looks like it won't cause problems, but I haven't been able to test it locally yet because of issues in my local environment relating to HStore field serialization. It seems like this is related to #119, so if it works for now we'll prioritize that upgrade first

@bnazari
Copy link
Contributor Author

bnazari commented Dec 12, 2017 via email

@pjsier
Copy link
Contributor

pjsier commented Jan 8, 2018

To close this one out, PubNub manages a lot of the real-time messaging functionality in the application. It can update the page with messages as they're received, but since we're getting an insecure content error right now that connection is blocked.

I tried out @bnazari's fix locally (adding a placeholder API key to make sure it loads the JS library), and it fixes the error. Updating the parameter only forces SSL connections if the current page isn't loaded over SSL, so this is pretty safe to update in general.

@pjsier pjsier merged commit 09390a4 into redcross:master Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants