refactor md functions into utils #67
Open
+64
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novanai
reviewed
Jan 16, 2025
src/utils.py
Outdated
| async with aiohttp_client.get(request_url) as response: | ||
| if response.status != 200: | ||
| raise Exception( | ||
| f"Failed to fetch the minutes. Status code: `{response.status}`" |
There was a problem hiding this comment.
I'd rather the aiohttp exception be raised with response.raise_for_status(). Then the specific aiohttp.ClientResponseError can be used in the except block instead of the generic Exception.
novanai
reviewed
Jan 16, 2025
src/extensions/agenda.py
Outdated
| if "https://md.redbrick.dcu.ie" not in url: | ||
| try: | ||
| content = await get_md_content(url, aiohttp_client) | ||
| except Exception as e: |
There was a problem hiding this comment.
Use aiohttp.ClientResponseError here for an error with the request, and add another except block for ValueError when the URL is invalid.
Or you could leave the URL validation here, and have get_md_content be purely be for making the request.
novanai
reviewed
Jan 16, 2025
src/extensions/agenda.py
Outdated
| new_agenda_url = response.url | ||
| try: | ||
| new_agenda_url = await post_new_md_content(modified_content, aiohttp_client) | ||
| except Exception as e: |
There was a problem hiding this comment.
Same as earlier comment, but only need to catch aiohttp.ClientResponseError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.