Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Revert "close #16 for every one with high res screen (#27)" #38

Merged
merged 1 commit into from
Oct 4, 2016

Conversation

SeanHealy33
Copy link
Contributor

This PR #27 was merged while pending review. As it didn't pass quality standards by me or @VoyTechnology its being reverted

This reverts commit 7b5357b.

@butlerx
Copy link
Member

butlerx commented Oct 4, 2016

this was holding up a push to production an requested reviews had be done

@butlerx butlerx closed this Oct 4, 2016
@butlerx butlerx deleted the seanhealy/revert branch October 4, 2016 20:52
Copy link
Collaborator

@GoldenBadger GoldenBadger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Voy and Sean had issues with it I don't think it should be ignored.

@VoyTechnology
Copy link
Contributor

Holding a push to production is not a valid excuse to submit anyways. The review was done, but merge not approved.

@SeanHealy33 SeanHealy33 restored the seanhealy/revert branch October 4, 2016 20:54
@SeanHealy33 SeanHealy33 reopened this Oct 4, 2016
@SeanHealy33 SeanHealy33 merged commit b73a048 into master Oct 4, 2016
@SeanHealy33 SeanHealy33 deleted the seanhealy/revert branch October 4, 2016 20:58
@butlerx butlerx mentioned this pull request Oct 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants