This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
close #16 for every one with high res screen #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butlerx
force-pushed
the
enhanchment/flex
branch
from
f5a50d9 to
c25745c
Compare
VoyTechnology
suggested changes
Oct 2, 2016
| </header> | ||
| <div class="container playlist"> | ||
| <iframe id="live" src="https://www.youtube.com/embed/videoseries?list=PLPaLJSHTDMFgYNnnEOjuvdm6WqOFTSQ9z" width="100%" height="400" marginwidth="0" marginheight="0" scrolling="no" frameborder="0" webkitallowfullscreen="" allowfullscreen=""></iframe> | ||
| <div class="main"> |
There was a problem hiding this comment.
We could use an actual <main> HTML5 element
There was a problem hiding this comment.
This is more a case of a bad class name
There was a problem hiding this comment.
It can be made better with <main> :)
There was a problem hiding this comment.
tbh when using it for appling style using class is better
There was a problem hiding this comment.
this isnt the main content of the page the main content would be the video and evens cards
|
Link issue in description |
|
@SeanHealy33 what? |
SeanHealy33
reviewed
Oct 3, 2016
| <span> </span> | ||
| <span> </span> | ||
| <span> </span> | ||
| <div class="main"> |
There was a problem hiding this comment.
What voy said before ⚡️
butlerx
force-pushed
the
enhanchment/flex
branch
from
40d5bc1 to
e3755cb
Compare
SeanHealy33
added a commit
that referenced
this pull request
Oct 4, 2016
butlerx
added a commit
that referenced
this pull request
Oct 4, 2016
butlerx
added a commit
that referenced
this pull request
Oct 4, 2016
butlerx
added a commit
that referenced
this pull request
Oct 5, 2016
butlerx
added a commit
that referenced
this pull request
Oct 5, 2016
butlerx
added a commit
that referenced
this pull request
Oct 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #16