Added remove_index #1
Conversation
| module Cop | ||
| module Migrations | ||
| # Your code goes here... | ||
| # Removing indexes is dangerous by nature, if the index you remove | ||
| # is used extensively, you could end up with database degradation. |
| end | ||
|
|
||
| end | ||
| end |
There was a problem hiding this comment.
What about testing when rubocop:disable Migrations/RemoveIndex comment is there?
There was a problem hiding this comment.
That is part of rubocop code. I have testes it manually and it works, but that functionality is not related with a cop itself, but is about rubocop.
|
👍 |
| @@ -1,2 +1,3 @@ | |||
| --format documentation | |||
| --color | |||
| --require spec_helper | |||
There was a problem hiding this comment.
putting this here has bitten me tons of times, but probably someone else told you that it is awesome 
There was a problem hiding this comment.
we don't use it on hosted and I'm not sure it's very common...
There was a problem hiding this comment.
I dropped it but does not show up... wonder why
|
📭 👍 |
magec
force-pushed
the
feature/remove_index_forbidden
branch
from
59060e5 to
b7e288c
Compare
| module Cop | ||
| module Migrations | ||
| # Your code goes here... | ||
| # Removing indexes is dangerous by nature, if the index you remove | ||
| # is used extensively, you could end up with database degradation. |
| class RemoveIndex < Cop | ||
| MSG = 'remove_index is disalowed'.freeze |
| spec.description = "" | ||
| spec.homepage = "" | ||
| spec.license = "MIT" | ||
| spec.authors = %w(enricostano magec) |
| spec.add_development_dependency "bundler", "~> 1.11" | ||
| spec.add_development_dependency "rake", "~> 10.0" | ||
| spec.add_development_dependency "rspec", "3.5.0" | ||
| spec.add_development_dependency 'bundler', '~> 1.11' |
There was a problem hiding this comment.
I believe the latest is 1.13 something. I would relax it more to be able to use the latest.
| @@ -1,2 +1,3 @@ | |||
| --format documentation | |||
| --color | |||
| --require spec_helper | |||
There was a problem hiding this comment.
we don't use it on hosted and I'm not sure it's very common...
|
👏 👍 |
WAT
Adds a check to disallow remove_index
GIF