Error handling in the Bridge #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StuartHarris
approved these changes
Feb 17, 2025
| ResolveSerialized::Once(_) => { | ||
| // The resolve has been used, turn it into a Never | ||
| if let ResolveSerialized::Once(f) = | ||
| std::mem::replace(self, ResolveSerialized::Never) | ||
| { | ||
| f(bytes); | ||
| f(bytes)? |
There was a problem hiding this comment.
I suppose it works because it's a result of unit type, just confusing because there's no semicolon, I guess
There was a problem hiding this comment.
Ah you're right, that just happens to be the same.
There was a problem hiding this comment.
Rewrote with let else and unreachable
| @@ -21,15 +21,24 @@ lazy_static! { | |||
|
|
|||
| #[wasm_bindgen] | |||
| pub fn process_event(data: &[u8]) -> Vec<u8> { | |||
| CORE.process_event(data) | |||
| match CORE.process_event(data) { | |||
There was a problem hiding this comment.
Aren't these effectively just unwrap()?
There was a problem hiding this comment.
I think the difference is just the message you get - the errors format pretty nicely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change
It allows serde and resolve errors in the bridge to be caught and inspected, so instead of crashing the core, they can be passed to telemetry, etc.
to do