Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-513: Shorten Volsync Job Name if exceeds 63 characters #469

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from

Conversation

ELENAGER
Copy link

@ELENAGER ELENAGER commented Mar 6, 2025

Fixes: https://issues.redhat.com/browse/DFBUGS-513
Also related to: backube/volsync#1470

The problem:
When replicating a Protected Application volumes via Volsync within the context of ACM Disaster recovery/Enroll Application/Discovered Application, it appears Volsync pre-pends "volsync-" when generating replicated PVC and "volsync-rsync-tls-src-" when generating Volsync Job/Pod names. The additional characters result in the error/failure within the corresponding ReplicationSource CR.

The solution:
Shorten PVC name in the job/service name

Signed-off-by: Elena Gershkovich [email protected]
(cherry picked from commit 0d7dce1)

Signed-off-by: Elena Gershkovich <[email protected]>
(cherry picked from commit 0d7dce1)
Copy link

openshift-ci bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ELENAGER

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2025

@ELENAGER: This pull request references [Jira Issue DFBUGS-513](https://issues.redhat.com//browse/DFBUGS-513), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Fixes: https://issues.redhat.com/browse/DFBUGS-513
Also related to: backube/volsync#1470

The problem:
When replicating a Protected Application volumes via Volsync within the context of ACM Disaster recovery/Enroll Application/Discovered Application, it appears Volsync pre-pends "volsync-" when generating replicated PVC and "volsync-rsync-tls-src-" when generating Volsync Job/Pod names. The additional characters result in the error/failure within the corresponding ReplicationSource CR.

The solution:
Shorten PVC name in the job/service name

Signed-off-by: Elena Gershkovich [email protected]
(cherry picked from commit 0d7dce1)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants