Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-1489: [release-4.17] : Remove duplicate placements for rook-ceph dameons due to specifying with all & specific key #2986

Open
wants to merge 3 commits into
base: release-4.17
Choose a base branch
from
Open

DFBUGS-1489: [release-4.17] : Remove duplicate placements for rook-ceph dameons due to specifying with all & specific key #2986

wants to merge 3 commits into from
+21 −41

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2983

/assign openshift-ci-robot

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 29, 2025
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign travisn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: [Jira Issue DFBUGS-1285](https://issues.redhat.com//browse/DFBUGS-1285) has been cloned as [Jira Issue DFBUGS-1489](https://issues.redhat.com//browse/DFBUGS-1489). Will retitle bug to link to clone.
/retitle [release-4.17] DFBUGS-1489: Remove duplicate placements for rook-ceph dameons due to specifying with all & specific key

In response to this:

This is an automated cherry-pick of #2983

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] DFBUGS-1285: Remove duplicate placements for rook-ceph dameons due to specifying with all & specific key [release-4.17] DFBUGS-1489: Remove duplicate placements for rook-ceph dameons due to specifying with all & specific key Jan 29, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-1489](https://issues.redhat.com//browse/DFBUGS-1489), which is invalid:

  • expected the bug to target the "odf-4.17.3" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #2983

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@malayparida2000 malayparida2000 mentioned this pull request Jan 29, 2025
Merged
@malayparida2000 malayparida2000 changed the title [release-4.17] DFBUGS-1489: Remove duplicate placements for rook-ceph dameons due to specifying with all & specific key DFBUGS-1489: [release-4.17] : Remove duplicate placements for rook-ceph dameons due to specifying with all & specific key Jan 29, 2025
@malayparida2000
Remove duplicate placements due to specifying with all & specific key
e40b665 
Rook creates some rook-ceph daemon's placement by merging the "all" and
specific key placements. The OCS operator specifies the default OCS
tolerations and node affinity in both the "all" key and the specific key
leading to duplicated placements. To avoid this, skip specifying the
default OCS tolerations and node affinity with the specific key.

Signed-off-by: Malay Kumar Parida <[email protected]>
@malayparida2000
Fix unit tests
6f0d825 
Signed-off-by: Malay Kumar Parida <[email protected]>
@malayparida2000
Fix go fmt issue, somehow CI missed it on the earlier PR
4714b6f 
Signed-off-by: Malay Kumar Parida <[email protected]>
@malayparida2000 malayparida2000 force-pushed the cherry-pick-2983-to-release-4.17 branch from cbf357c to 4714b6f Compare January 29, 2025 09:31
@malayparida2000
Copy link
Contributor

/retest

6 similar comments
@malayparida2000
Copy link
Contributor

/retest

@malayparida2000
Copy link
Contributor

/retest

@malayparida2000
Copy link
Contributor

/retest

@malayparida2000
Copy link
Contributor

/retest

@malayparida2000
Copy link
Contributor

/retest

@malayparida2000
Copy link
Contributor

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocs-operator-bundle-e2e-aws 4714b6f link true /test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@openshift-ci-robot openshift-ci-robot

Labels
jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @malayparida2000