Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node toleration to alertmanager and prometheus pods #2969

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

rohan47
Copy link
Contributor

@rohan47 rohan47 commented Jan 17, 2025

Platform related metrics and alerts pods deployed by ODF do not have spec.tolerations with node.ocs.openshift.io/storage when taint nodes performed. This PR adds the required tolerations

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025

@rohan47: This pull request references [Jira Issue DFBUGS-1272](https://issues.redhat.com//browse/DFBUGS-1272), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Platform related metrics and alerts pods deployed by ODF do not have spec.tolerations with node.ocs.openshift.io/storage when taint nodes performed. This PR adds the required tolerations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 17, 2025
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

Hi @rohan47. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rohan47 rohan47 changed the title DFBUGS-1272: [release-4.18] Add node toleration to alertmanager and prometheus pods Add node toleration to alertmanager and prometheus pods Jan 20, 2025
@openshift-ci-robot openshift-ci-robot removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 20, 2025
@openshift-ci-robot
Copy link

@rohan47: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Platform related metrics and alerts pods deployed by ODF do not have spec.tolerations with node.ocs.openshift.io/storage when taint nodes performed. This PR adds the required tolerations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@ezio-auditore ezio-auditore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Please verify changes if it is working as it should

@iamniting
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2025
@rohan47 rohan47 changed the title Add node toleration to alertmanager and prometheus pods DFBUGS-1272: Add node toleration to alertmanager and prometheus pods Jan 27, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Jan 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 27, 2025

@rohan47: This pull request references [Jira Issue DFBUGS-1272](https://issues.redhat.com//browse/DFBUGS-1272), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

Platform related metrics and alerts pods deployed by ODF do not have spec.tolerations with node.ocs.openshift.io/storage when taint nodes performed. This PR adds the required tolerations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohan47
Copy link
Contributor Author

rohan47 commented Jan 27, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 27, 2025

@rohan47: This pull request references [Jira Issue DFBUGS-1272](https://issues.redhat.com//browse/DFBUGS-1272), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@iamniting
Copy link
Member

@rohan47 bugs are not required for the main branch. We only need them to backport.

@iamniting iamniting changed the title DFBUGS-1272: Add node toleration to alertmanager and prometheus pods Add node toleration to alertmanager and prometheus pods Jan 27, 2025
@openshift-ci-robot openshift-ci-robot removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Jan 27, 2025
@openshift-ci-robot
Copy link

@rohan47: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Platform related metrics and alerts pods deployed by ODF do not have spec.tolerations with node.ocs.openshift.io/storage when taint nodes performed. This PR adds the required tolerations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@iamniting
Copy link
Member

/cherry-pick release-4.18

@openshift-cherrypick-robot

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iamniting
Copy link
Member

@rohan47 @ezio-auditore Is the PR tested?

@rohan47
Copy link
Contributor Author

rohan47 commented Jan 29, 2025

The PR is tested @iamniting

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, rohan47

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f95fd39 into red-hat-storage:main Jan 29, 2025
11 checks passed
@openshift-cherrypick-robot

@iamniting: new pull request created: #2988

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants