add support for enabling clusterwide encryption as day-2 operation #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
sp98
force-pushed
the
enable-encryption-day-2
branch
from
7f08913 to
e6e8c14
Compare
Signed-off-by: Santosh Pillai <[email protected]>
sp98
force-pushed
the
enable-encryption-day-2
branch
from
e6e8c14 to
7afd693
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/assign @iamniting |
iamniting
requested changes
Jan 17, 2025
| // isEncrptionSettingUpdated checks whether ecryption was enabled or disabled for the storageClassDeviceSet. | ||
| func isEncrptionSettingUpdated(newDeviceSet, existingDeviceSet []rookCephv1.StorageClassDeviceSet) bool { | ||
| if len(newDeviceSet) != len(existingDeviceSet) { | ||
| return false |
There was a problem hiding this comment.
I believe this is an unknown state instead of false, Is sending false safe here?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sp98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On existing ODF clusters, customers can enable
clusterwideencryption by enablingspec.Encryption.ClusterWidetotrue. Rook will destroy the OSDs are recreate them with same OSD ID after enabling encryption.EPIC - https://issues.redhat.com/browse/RHSTOR-6075