Add CSI_REMOVE_HOLDER_PODS key and its value in the ocs configmap

[iamniting]

set the CSI_REMOVE_HOLDER_PODS to true for new users on version 4.16 onwards and set it to false for older/upgraded user to give them time to migrate manually.

with version 4.17 we will make the CSI_REMOVE_HOLDER_PODS to true for all customers older and new both.

If the configmap is being created for the first time we are considering it as a new install.

Signed-off-by: Nitin Goyal [email protected]

Jira: https://issues.redhat.com/browse/RHSTOR-5340?focusedId=24357013&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-24357013

[iamniting]

/hold

[iamniting]

/unhold

[iamniting]

@subhamkrai once this PR is merged can you pls read this key from the ocs-operator-config configmap in the rook deployment?

[malayparida2000]

The bundle separation PR #2492 is not yet merged. So it will be appropriate to add the change for reading this as env variable to the csv in the csv-merger. This will make sure after that PR is merged all the mentioned env vars are properly migrated to the rook ds repo csv.

[subhamkrai]

@subhamkrai once this PR is merged can you pls read this key from the ocs-operator-config configmap in the rook deployment?

suree

[iamniting]

The bundle separation PR #2492 is not yet merged. So it will be appropriate to add the change for reading this as env variable to the csv in the csv-merger. This will make sure after that PR is merged all the mentioned env vars are properly migrated to the rook ds repo csv.

I am not doing that because if we do so we will have merge conflicts in the other PR where we are removing the rook CSV.

[malayparida2000]

The bundle separation PR #2492 is not yet merged. So it will be appropriate to add the change for reading this as env variable to the csv in the csv-merger. This will make sure after that PR is merged all the mentioned env vars are properly migrated to the rook ds repo csv.

I am not doing that because if we do so we will have merge conflicts in the other PR where we are removing the rook CSV.

That should be okay right? I just want to make sure that all the env vars defined in the csv merger get transferred directly to the rook ds. If we don't want the merge conflict, IMO we should wait till the bundle separation PR merges and then merge this.

[iamniting]

The bundle separation PR #2492 is not yet merged. So it will be appropriate to add the change for reading this as env variable to the csv in the csv-merger. This will make sure after that PR is merged all the mentioned env vars are properly migrated to the rook ds repo csv.

I am not doing that because if we do so we will have merge conflicts in the other PR where we are removing the rook CSV.

That should be okay right? I just want to make sure that all the env vars defined in the csv merger get transferred directly to the rook ds. If we don't want the merge conflict, IMO we should wait till the bundle separation PR merges and then merge this.

I don't want to delay the PRs as we are near the feature freeze.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, subhamkrai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [iamniting]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment