add suffix for external ceph client secret name during gRPC response #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leelavg
force-pushed
the
5487-change-secret
branch
from
84ff31b to
b58aa8c
Compare
|
Testing |
|
/lgtm |
openshift-ci
bot
added
lgtm
Madhu-1
reviewed
Mar 20, 2024
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@nb-ohad we can remove the hold and address #2512 (comment) in a different PR? |
|
/retest-required |
when provider & client are running in same namespace the cephclient secret name clashes and as the contents will be different we'll add a suffix ".csi" to the secret which wll be managed by client. Signed-off-by: Leela Venkaiah G <[email protected]>
leelavg
force-pushed
the
5487-change-secret
branch
from
b58aa8c to
a88b7be
Compare
|
rebased to pull in latest changes for CI. |
|
/retest |
|
/test ocs-operator-bundle-e2e-aws |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 45e1370
into
red-hat-storage:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when provider & client are running in same namespace the cephclient secret name clashes and as the contents will be different we'll add a suffix ".csi" to the secret which wll be managed by client.
Part of [RHSTOR-5487]