disable holder pods in greenfield clusters #2508
Conversation
When deploying new StorageClusters, ocs-operator should apply the new Rook operator config `CSI_REMOVE_HOLDER_PODS: "true"`. This reflects the new config and default value that Rook specifies in example manifests here: rook/rook#13890 Signed-off-by: Blaine Gardner <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlaineEXE The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
There was a problem hiding this comment.
Hey Blaine, here the added value just went to the ocs-operator-config CM. We also need to add them as env variables to the rook-csv in the csv-merger https://github.com/red-hat-storage/ocs-operator/blob/c65c08c6ff670afe39890ffda5117d2ab7749ca1/tools/csv-merger/csv-merger.go#L306(so that it reads the value from the configmap).
But that process is also undergoing a change right now. #2492 (comment).
Also if we add the value this way it will be also applicable to existing clusters. We have to think of some hack to avoid setting the value in existing clusters.
There was a problem hiding this comment.
@BlaineEXE We currently lack the mechanism to determine whether the cluster is a new one or an upgraded one. How do you think we can achieve what we wanted to do here.
|
@malayparida2000 I see I made a mistake here. Thanks for catching that. I'm not sure how ocs-operator handles the CSV, so I am not quite sure what to do here. I'll close this PR, and I think I will need some help accomplishing the goals here. |
When deploying new StorageClusters, ocs-operator should apply the new Rook operator config
CSI_REMOVE_HOLDER_PODS: "true". This reflects the new config and default value that Rook specifies in example manifests here: rook/rook#13890This new value should be applied to the
rook-ceph-operator-configonly during installation of new (greenfield) StorageClusters.It is required that ocs-operator should not update this value in existing (brownfield) clusters.