storageclassrequest: remove use of StorageProfiles with blockpools

Signed-off-by: Jose A. Rivera <[email protected]>

controllers/storageclassrequest/storageclassrequest_controller_test.go

@@ -435,7 +435,7 @@ func TestCephBlockPool(t *testing.T) {
 						Name:      "test-blockpool",
 						Namespace: "test-ns",
 						Labels: map[string]string{
-							controllers.StorageProfileSpecLabel: fakeStorageProfile.GetSpecHash(),
+							controllers.StorageProfileLabel: fakeStorageProfile.Name,
 						},
 					},
 				},
@@ -444,7 +444,7 @@ func TestCephBlockPool(t *testing.T) {
 						Name:      "test-blockpool2",
 						Namespace: "test-ns",
 						Labels: map[string]string{
-							controllers.StorageProfileSpecLabel: fakeStorageProfile.GetSpecHash(),
+							controllers.StorageProfileLabel: fakeStorageProfile.Name,
 						},
 					},
 				},
@@ -512,7 +512,7 @@ func TestCephBlockPool(t *testing.T) {
 						Name:      "test-blockpool",
 						Namespace: "test-ns",
 						Labels: map[string]string{
-							controllers.StorageProfileSpecLabel: fakeStorageProfile.GetSpecHash(),
+							controllers.StorageProfileLabel: fakeStorageProfile.Name,
 						},
 					},
 				},
@@ -608,22 +608,6 @@ func TestCephBlockPool(t *testing.T) {
 		err = r.get(expectedRadosNamespace)
 		assert.NoError(t, err, caseLabel)
 	}
-
-	caseCounter++
-	caseLabel := fmt.Sprintf("Case %d: StorageProfile has invalid DeviceClass", caseCounter)
-	fmt.Println(caseLabel)
-
-	badStorageProfile := fakeStorageProfile.DeepCopy()
-	badStorageProfile.Spec.DeviceClass = "nope"
-
-	r := createFakeReconciler(t)
-	r.StorageClassRequest.Spec.Type = "blockpool"
-	r.StorageClassRequest.Spec.StorageProfile = badStorageProfile.Name
-	fakeClient := newFakeClientBuilder(r.Scheme)
-	r.Client = fakeClient.WithRuntimeObjects(badStorageProfile, fakeStorageConsumer).Build()
-
-	_, err = r.reconcilePhases()
-	assert.Error(t, err, caseLabel)
 }
 
 func TestCephFsSubVolGroup(t *testing.T) {