DFBUGS-943: Fix key and ownerRef bug #241
Conversation
namespace + "/" + leader identity(pod name) is the key for the connection. this key is used by GetLeaderByDriver to get the connection. csi-lib-utils/leaderelection:sanitizeName() is used to sanitize the leader identity used for the leases csiaddonsnode need to store the key with same format so that it can be used to get the connection. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 6c31248)
The pod might move to new nodes and this might create the stale CSIAddonsNode object. so, we need to set the pod as the owner for the deployment as we dont store any details that are required later on for any other operations like Fencing etc. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit f037599)
|
@Madhu-1: No Jira issue with key BFBUGS-943 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Madhu-1
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@Madhu-1: This pull request references [Jira Issue DFBUGS-943](https://issues.redhat.com//browse/DFBUGS-943), which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jilju. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
@black-dragon74: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nixpanic @Rakshith-R we need LGTM on this one |
|
/assign @iPraveenParihar |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: black-dragon74, iPraveenParihar, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit da1d39c
into
red-hat-storage:release-4.18
|
@Madhu-1: [Jira Issue DFBUGS-943](https://issues.redhat.com//browse/DFBUGS-943): All pull requests linked via external trackers have merged: [Jira Issue DFBUGS-943](https://issues.redhat.com//browse/DFBUGS-943) has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is a backport PR of csi-addons#718 to 4.18 branch, This is alaredy synced to downstream main branch