Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added iscsi validations #4402

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Added iscsi validations #4402

merged 2 commits into from
Feb 3, 2025
+239 −13

Conversation

sunilkumarn417
Copy link
Contributor

@sunilkumarn417 sunilkumarn417 commented Jan 27, 2025 •
edited
Loading

Description

  • Added validations on iscsi sanity. Every entity configured is cross-verified with export configuration data.
  • Added sanity for reef builds

All test logs located here: /Users/sunilkumarn/logs/8_0-z2-iscsi-validations-07

TEST NAME                        TEST DESCRIPTION                                               DURATION                         STATUS                    COMMENTS
Ceph iSCSI Sanity e2e test       Configure iSCSI gateways, initiators and run IO                0:06:38.793412                   Pass

@sunilkumarn417 sunilkumarn417 requested review from a team as code owners January 27, 2025 13:46
@sunilkumarn417
iscsi sanity for reef
3d11356 
Signed-off-by: Sunil Kumar Nagaraju <sunnagar@redhat.com>
@sunilkumarn417
Added iscsi validations
c7a2d4c 
Signed-off-by: Sunil Kumar Nagaraju <sunnagar@redhat.com>
krishnaramaswamy
krishnaramaswamy approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@krishnaramaswamy krishnaramaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!..

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 30, 2025
Manohar-Murthy
Manohar-Murthy approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Manohar-Murthy Manohar-Murthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aarsharm, krishnaramaswamy, Manohar-Murthy, psathyan, sunilkumarn417

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit 48e19f8 into red-hat-storage:main Feb 3, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manohar-Murthy Manohar-Murthy

@psathyan psathyan

@krishnaramaswamy krishnaramaswamy

@aarsharm aarsharm

@manasagowri manasagowri

@AmarnatReddy AmarnatReddy

@vamahaja vamahaja

Assignees

@Manohar-Murthy Manohar-Murthy

@psathyan psathyan

@krishnaramaswamy krishnaramaswamy

@aarsharm aarsharm

Labels
iscsi lgtm Add this label when the PR is good to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sunilkumarn417 @Manohar-Murthy @psathyan @krishnaramaswamy @aarsharm