Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-1320: add check to getVolumeReplicationInfo #448

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

DFBUGS-1320: add check to getVolumeReplicationInfo #448

wants to merge 1 commit into from

Conversation

yati1998
Copy link
Member

this commit adds a check to getVolumeReplicationInfo to include status not found error while getting the remote status.
This helps the failover to be done even if remote site status is not found

Signed-off-by: yati1998 [email protected]
(cherry picked from commit a5f6d89)

@yati1998
rbd: add check to getVolumeReplicationInfo
05d944c 
this commit adds a check to getVolumeReplicationInfo
to include status not found error while getting the
remote status.
This helps the failover to be done even if remote site status
is not found

Signed-off-by: yati1998 <[email protected]>
(cherry picked from commit a5f6d89)
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2025 •
edited by openshift-ci bot
Loading

@yati1998: This pull request references [Jira Issue DFBUGS-1320](https://issues.redhat.com//browse/DFBUGS-1320), which is invalid:

  • expected the bug to target the "odf-4.17.3" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

this commit adds a check to getVolumeReplicationInfo to include status not found error while getting the remote status.
This helps the failover to be done even if remote site status is not found

Signed-off-by: yati1998 [email protected]
(cherry picked from commit a5f6d89)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Jan 14, 2025
@yati1998
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2025 •
edited by openshift-ci bot
Loading

@yati1998: This pull request references [Jira Issue DFBUGS-1320](https://issues.redhat.com//browse/DFBUGS-1320), which is invalid:

  • expected the bug to target the "odf-4.17.3" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Madhu-1
Copy link
Member

Madhu-1 commented Jan 15, 2025

@yati1998 please get the fix first synced to the devel branch and then backport it to 4.18 and later to 4.17.

@yati1998
Copy link
Member Author

/retest

@nixpanic
Copy link
Member

/retest

@yati1998 , there is no /retest for GitHub Actions. You need to click the Details link in the CI job, and then Re-run jobs in the upper right corner:
image

@nixpanic
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025 •
edited by openshift-ci bot
Loading

@nixpanic: This pull request references [Jira Issue DFBUGS-1320](https://issues.redhat.com//browse/DFBUGS-1320), which is invalid:

  • expected the bug to target the "odf-4.17.3" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nixpanic
Copy link
Member

expected the bug to target the "odf-4.17.3" version, but no target version was set

This is planned for inclusion in "odf-4.17.4", it seems.

@nixpanic
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2025 •
edited by openshift-ci bot
Loading

@nixpanic: This pull request references [Jira Issue DFBUGS-1320](https://issues.redhat.com//browse/DFBUGS-1320), which is invalid:

  • expected the bug to target the "odf-4.17.3" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yati1998
Copy link
Member Author

yati1998 commented Feb 8, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2025 •
edited by openshift-ci bot
Loading

@yati1998: This pull request references [Jira Issue DFBUGS-1320](https://issues.redhat.com//browse/DFBUGS-1320), which is invalid:

  • expected the bug to target either version "odf-4.17.3." or "openshift-odf-4.17.3.", but it targets "odf-4.17.5" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Its a good idea jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yati1998 @openshift-ci-robot @Madhu-1 @nixpanic