Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundle: adjust for Konflux onboarding, 2.13 #2373

Open
wants to merge 2 commits into
base: rhoai-2.13
Choose a base branch
from
Open

bundle: adjust for Konflux onboarding, 2.13 #2373

wants to merge 2 commits into from
+106 −151

Conversation

ykaliuta
Copy link

@ykaliuta ykaliuta commented Jan 29, 2025 •
edited
Loading

Jira: https://issues.redhat.com/browse/RHOAIENG-18668

For CSV Take CPaaS manifests and remove template variables

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Sorry, something went wrong.

@ykaliuta ykaliuta marked this pull request as draft January 29, 2025 17:22
@ykaliuta ykaliuta force-pushed the jira-rhoaieng-18668-konflux-2.13 branch from 193bd5f to da29da5 Compare February 11, 2025 13:34
@ykaliuta ykaliuta marked this pull request as ready for review February 11, 2025 13:35
zdtsw
zdtsw reviewed Feb 13, 2025
View reviewed changes
Copy link

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better ask DevOps for review too, with some questions i added here

@ykaliuta ykaliuta force-pushed the jira-rhoaieng-18668-konflux-2.13 branch from 51b3fcf to 2fb6f63 Compare February 13, 2025 13:58
@ykaliuta
Copy link
Author

/cc @dchourasia

@dchourasia
Copy link

@ykaliuta overall it will be useful to look at the CSV at this location which we have drafted to be used with the Konflux build, that should help with all the changes required here https://github.com/red-hat-data-services/RHOAI-Build-Config/blob/rhoai-2.13/to-be-processed/bundle/manifests/rhods-operator.clusterserviceversion.yaml

@ykaliuta
Copy link
Author

ykaliuta commented Mar 5, 2025

@ykaliuta overall it will be useful to look at the CSV at this location which we have drafted to be used with the Konflux build, that should help with all the changes required here https://github.com/red-hat-data-services/RHOAI-Build-Config/blob/rhoai-2.13/to-be-processed/bundle/manifests/rhods-operator.clusterserviceversion.yaml

Thanks! I'll have a look

@ykaliuta
bundle: rhods-operator CSV: commit CPaaS version
f0b03d4 
Prepare for konflux build.

Sync with CPaaS.

Commit CPaaS version as is before adjusting to konflux.

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
@ykaliuta ykaliuta force-pushed the jira-rhoaieng-18668-konflux-2.13 branch from 2fb6f63 to c2e096c Compare March 5, 2025 11:08
@ykaliuta
bundle: rhods-operator CSV: amend CPaaS version for Konflux
71ebfa9 
Replace variables values with placehoulders
- name (rhods-operator.NAME)
- containerImage (REPLACE_IMAGE:latest)
- createdAt (REPLACE_DATE)
- version (REPLACE_VERSION)
- image (REPLACE_IMAGE:latest)

Remove "RELATED_IMAGE*" environment variables.
Remove images from annotations.
Removed fields:
- replaces
- olm.skipRange

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
@ykaliuta ykaliuta force-pushed the jira-rhoaieng-18668-konflux-2.13 branch from c2e096c to 71ebfa9 Compare March 5, 2025 11:24
@ykaliuta
Copy link
Author

ykaliuta commented Mar 5, 2025

@dchourasia sorry for disturbing, can you do final check and confirmation (for both PRs)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdtsw zdtsw

@dchourasia dchourasia

@riprasad riprasad

Assignees
No one assigned
Labels
rhoai-2.13.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ykaliuta @dchourasia @zdtsw @riprasad