Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core) add attachment/supdoc support #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(core) add attachment/supdoc support #11

wants to merge 2 commits into from

Conversation

JAertgeerts
Copy link

@JAertgeerts JAertgeerts commented Jun 6, 2024 •
edited
Loading

red-coracle
red-coracle requested changes Jun 13, 2024
View reviewed changes
Copy link
Owner

@red-coracle red-coracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Let me know if you see a reason not to use the default factories and I can add a test case as well.

pyintacct/models/company.py Outdated Show resolved Hide resolved
@JAertgeerts JAertgeerts force-pushed the feature/attachments branch from c390029 to 90942f6 Compare June 18, 2024 19:22
@JAertgeerts
Copy link
Author

Thank you for the PR! Let me know if you see a reason not to use the default factories and I can add a test case as well.

hey! I've made the change, you're right to use the default factory 👍 . I've also added tests.

@JAertgeerts JAertgeerts force-pushed the feature/attachments branch 2 times, most recently from 810445c to d8a154f Compare June 19, 2024 13:19
@red-coracle red-coracle force-pushed the feature/attachments branch from d8a154f to 27c407e Compare June 19, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-coracle red-coracle red-coracle requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JAertgeerts @red-coracle