Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a close channel in order to finish the dial loop #28

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

p4u
Copy link
Contributor

@p4u p4u commented Oct 5, 2020

This is required in order to terminate the connect() lopp.

If this is not applied, after calling Close() the connect goroutine would keep iterating and trying to reconnect

Signed-off-by: p4u pau@dabax.net

before, connect() would keep iterating fater connection close

Signed-off-by: p4u <pau@dabax.net>
@loeffel-io
Copy link
Member

thanks for your contribution!

btw: is this also solving #20 ?

@p4u
Copy link
Contributor Author

p4u commented Oct 6, 2020

Probably yes, but I am not sure if there is some other corner case that could trigger this issue.

@loeffel-io loeffel-io merged commit 33a2857 into recws-org:master Oct 19, 2020
@loeffel-io
Copy link
Member

alright, thanks man

@loeffel-io
Copy link
Member

released in v1.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants