Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary pin php-parser to 5.3.1 #6636

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 30, 2024

nikic/php-parser 5.4.0 just released https://github.com/nikic/PHP-Parser/releases/tag/v5.4.0 , and this cause vendor patches error:


   Could not apply patch! Skipping. The error was: Cannot apply patch 
https://raw.githubusercontent.com/rectorphp/vendor-patches/main/patches/nikic-php-parser-lib-phpparser-nodetraverser-php.patch

Error: Cannot apply patch 15 (https://raw.githubusercontent.com/rectorphp/vendor-patches/main/patches/nikic-php-parser-lib-phpparser-nodetraverser-php.patch)!

see https://github.com/rectorphp/rector-src/actions/runs/12545721446/job/34980384434

This patch temporary pin to 5.3.1 to update vendor patches later.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit eb272ee into main Dec 30, 2024
41 checks passed
@samsonasik samsonasik deleted the temporary-pin-php-parser branch December 30, 2024 11:17
@TomasVotruba
Copy link
Member

👍

Beware once PHPStan bumps to this version, we'll have a BC breaks most likely

@samsonasik
Copy link
Member Author

I will create PR into vendor-patches to handle php-parser 5.4.0 :)

@samsonasik
Copy link
Member Author

@samsonasik
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants