[CodeQuality] Skip fopen() or die() on LogicalToBooleanRector on assign

[samsonasik]

Hi @lvanstrijland

I finally found a real use case when or should be kept, on fopen() or die() when assigned:

        $file = fopen($fileLocation, 'w') or die('Unable to open file!');
        fwrite($file, "John Doe\nJane Doe\n");
        fclose($file);

with ||, $file become bool instead of resource when file opened.

Ref rectorphp/rector#7604

[samsonasik]

Fixed 🎉 /cc @lvanstrijland

[samsonasik]

I added assign check to ensure this patch on this specific condition :)

ad2defd

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it ;)

[lvanstrijland]

@samsonasik ah yeah this a much better example now that I read my post from 2022 haha.

This use case is a better example for the difference between or and ||.

Thanks for the fix!