New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Skip with string key append on ForeachItemsAssignToEmptyArrayToAssignRector #6634

Closed

samsonasik wants to merge 1 commit into main from skip-with-string-key

Member

samsonasik commented Dec 29, 2024

Fixes rectorphp/rector#8953

Ref https://getrector.com/demo/20293375-a4e5-4bd5-9bbd-1bc5d5843a24
Ref https://3v4l.org/n3j95 vs https://3v4l.org/oriZn


          [CodeQuality] Skip with string key append on ForeachItemsAssignToEmpt…

1fbcb7b

…yArrayToAssignRector

samsonasik marked this pull request as draft

December 29, 2024 17:41

Member Author

samsonasik commented Dec 29, 2024

Closing for now, on specific use case, direct ->withSkip() is the way to go as key by can be different, even integer type.

samsonasik closed this

samsonasik deleted the skip-with-string-key branch

December 29, 2024 18:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet