add assign condition to ensure patch on this specific use case

rectorphp · Dec 30, 2024 · ad2defd · ad2defd
1 parent 9cf83fb
commit ad2defd
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/rules/CodeQuality/Rector/LogicalAnd/LogicalToBooleanRector.php b/rules/CodeQuality/Rector/LogicalAnd/LogicalToBooleanRector.php
@@ -5,6 +5,7 @@
 namespace Rector\CodeQuality\Rector\LogicalAnd;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
 use PhpParser\Node\Expr\BinaryOp\BooleanOr;
 use PhpParser\Node\Expr\BinaryOp\LogicalAnd;
@@ -55,7 +56,7 @@ public function refactor(Node $node): BooleanAnd|BooleanOr|null
     {
         $type = $this->nodeTypeResolver->getNativeType($node->left);
 
-        if (! $type->isBoolean()->yes()) {
+        if ($node->left instanceof Assign && ! $type->isBoolean()->yes()) {
             return null;
         }