This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
フォームの表示 #4
Open
フォームの表示 #4
+94
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quramy
reviewed
Apr 27, 2021
src/index.ts
Outdated
| <input type="${item.type}" id="${x.label}" name="${item.name}" value="${x.value}"> | ||
| <label for="${x.label}">${x.label}</label>` | ||
| ) | ||
| .reduce((s, x) => s + x); |
There was a problem hiding this comment.
文字列の配列を連結する際は .join("") が使えたりします。
Quramy
reviewed
Apr 27, 2021
| const inputs_html = item.values | ||
| .map( | ||
| (x) => ` | ||
| <input type="${item.type}" id="${x.label}" name="${item.name}" value="${x.value}"> |
There was a problem hiding this comment.
name属性の扱いについて、 radio と checkbox で扱いが同じでよいか？ということを考えてみるとよいと思います。
型としては両方 MultipleValueInputItems として扱ってよいのですが、出力されるHTMLがこれで問題ないか（ = チェックボックスのnameが全valuesで同じ値になってしまっている) 点は要注意ですね
There was a problem hiding this comment.
これ、私も同じことをしていたのですが、 type=checkbox で同一の name 属性を持つものが複数存在することは問題ないのではないか、と思ったのですが、何か問題があるのでしょうか……?
Quramy
reviewed
Apr 27, 2021
| type SingleValueInputItems = | ||
| | SingleValueInputItem<"text"> | ||
| | SingleValueInputItem<"email"> | ||
| | SingleValueInputItem<"tel">; |
There was a problem hiding this comment.
Genericsを使ってコード量を上手に削減していますね、とてもよい工夫だと思います 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.