-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from github:main #2
base: main
Are you sure you want to change the base?
Conversation
h2, | ||
p, | ||
h3 { | ||
direction: rtl; /* Right to Left */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use //
comments everywhere
@@ -250,3 +250,13 @@ blockquote { | |||
.form-select { | |||
-webkit-appearance: none; | |||
} | |||
|
|||
*:lang(fa) { | |||
.article-body, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 0 spaces
cursor: pointer; | ||
padding: 10px; | ||
border-radius: 4px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files should end with a trailing newline
border: none; | ||
cursor: pointer; | ||
padding: 10px; | ||
border-radius: 4px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 4 spaces
color: #fff; | ||
border: none; | ||
cursor: pointer; | ||
padding: 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 4 spaces
background-color: #333; | ||
color: #fff; | ||
border: none; | ||
cursor: pointer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 4 spaces
font-size: 16px; | ||
background-color: #333; | ||
color: #fff; | ||
border: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 4 spacesborder: 0
is preferred over border: none
display: none; | ||
position: fixed; | ||
bottom: 20px; | ||
right: 20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 4 spaces
#scrollToTopButton { | ||
display: none; | ||
position: fixed; | ||
bottom: 20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 4 spaces
@@ -0,0 +1,14 @@ | |||
#scrollToTopButton { | |||
display: none; | |||
position: fixed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 4 spaces
@@ -0,0 +1,14 @@ | |||
#scrollToTopButton { | |||
display: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 4 spaces
Properties should be ordered background-color, border, border-radius, bottom, color, cursor, display, font-size, padding, position, right, z-index
@@ -0,0 +1,14 @@ | |||
#scrollToTopButton { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using id selectors
Rule set contains (12/10) properties
Selector scrollToTopButton
should be written in lowercase with hyphens
"zh-hans": "章节", | ||
); | ||
|
||
@each $locale, $translation in $section_translation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of variable section_translation
should be written in all lowercase letters with hyphens instead of underscores
|
||
// Enter the locale code and the translation of "Section" in the language. | ||
// The country code should be the same as the value of the lang attribute in html (use "-" instead of "_") | ||
$section_translation: ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of variable section_translation
should be written in all lowercase letters with hyphens instead of underscores
Prior to this change the tests would fail with: Checking 358 external links... Ran on 300 files! - _site/pcm/best-practices/index.html * linking to internal hash #share-ownership-of-your-project that does not exist (line 557) <a href="../building-community/#share-ownership-of-your-project">share ownership of the project</a> This fixes the internal anchor to match the translated header text.
Fix test failure caused by untranslated internal link
… link again after # in the building-community.md file
…y.md according to the test errors
There have been 2 major revs of HTML-Proofer since the one we pinned. The current one is causing flaky tests - it's missing clear errors w/internal links and only reports the first error it finds rather than running to completion and reporting all of them. The latest version (5.0.8 at the moment) does catch all of the errors but has a problem locally where UTF-8 encoded anchor links are not properly decoded. This might be a problem local to me though; I coded up a spec test in html-proofer with an exact copy-paste of one of the failing links and ... it passes there. So i'll unpin this and see if there's some local gem issue that's causing this on my machine and maybe it works in the Actions env.
based on html-proofer's UPGRADING.md , many of the old configuration directives have changed names in the new version.
Create Bulgarian translation
Fix data structure problem in bg
Signed-off-by: jmeridth <[email protected]>
fix: prefix a checkout action usage semver with 'v'
Bumps the dependencies group with 1 update in the / directory: [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `ruby/setup-ruby` from 1.207.0 to 1.213.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@4a9ddd6...28c4ded) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…encies-d7fb325b12 chore(deps): bump ruby/setup-ruby from 1.207.0 to 1.213.0 in the dependencies group across 1 directory
translate to persian
paypal.github.io no longer exists
Initial pull request for Bangla translation
Bumps the dependencies group with 1 update: [actions/setup-node](https://github.com/actions/setup-node). Updates `actions/setup-node` from 4.1.0 to 4.2.0 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4.1.0...v4.2.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…encies-c2de478214 chore(deps): bump actions/setup-node from 4.1.0 to 4.2.0 in the dependencies group
Fix Typo in German Document
Bumps the dependencies group with 1 update: [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `ruby/setup-ruby` from 1.213.0 to 1.214.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@28c4ded...1287d2b) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…encies-a1f8218ba2 chore(deps): bump ruby/setup-ruby from 1.213.0 to 1.214.0 in the dependencies group
fix: Corrected typos and rephrased sentences
- Add missing newline at the end of the file - Remove consecutive blank lines before line 119
Bumps the dependencies group with 1 update: [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `ruby/setup-ruby` from 1.214.0 to 1.215.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@1287d2b...2654679) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…encies-bca743b640 chore(deps): bump ruby/setup-ruby from 1.214.0 to 1.215.0 in the dependencies group
Translate 'Maintaining Balance for Open Source Maintainers' into Korean
Bumps the dependencies group with 1 update: [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `ruby/setup-ruby` from 1.215.0 to 1.216.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@2654679...8388f20) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…encies-ff06419e08 chore(deps): bump ruby/setup-ruby from 1.215.0 to 1.216.0 in the dependencies group
Bumps the dependencies group with 1 update: [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `ruby/setup-ruby` from 1.216.0 to 1.218.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@8388f20...d781c1b) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…encies-dcb567d975 chore(deps): bump ruby/setup-ruby from 1.216.0 to 1.218.0 in the dependencies group
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )