Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reana-dev): add PR number in commit to bump shared modules (#783) #783

Merged

Conversation

mdonadoni
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 18.56%. Comparing base (a6f95ac) to head (c533c34).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
- Coverage   18.63%   18.56%   -0.07%     
==========================================
  Files          26       26              
  Lines        2345     2359      +14     
==========================================
+ Hits          437      438       +1     
- Misses       1908     1921      +13     
Files Coverage Δ
reana/reana_dev/git.py 29.13% <0.00%> (ø)
reana/reana_dev/utils.py 36.14% <6.66%> (-1.02%) ⬇️

Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely.

A suggestion for the commit headline:

fix(reana-dev): add PR number in commits bumping shared modules (#783)

(otherwise people could read "to bump..." as a reason for the change)

mdonadoni added a commit to mdonadoni/reana that referenced this pull request Mar 1, 2024
@mdonadoni mdonadoni force-pushed the fix-pr-number-upgrade-shared-modules branch from 50edef3 to 9e9532d Compare March 1, 2024 10:47
@mdonadoni mdonadoni force-pushed the fix-pr-number-upgrade-shared-modules branch from 9e9532d to 19e3874 Compare March 1, 2024 10:48
@mdonadoni mdonadoni force-pushed the fix-pr-number-upgrade-shared-modules branch from 19e3874 to c533c34 Compare March 1, 2024 10:51
@mdonadoni mdonadoni requested a review from tiborsimko March 1, 2024 10:51
@mdonadoni
Copy link
Member Author

I have also improved reana-dev to detect whether a PR was already open or not

@mdonadoni mdonadoni merged commit c533c34 into reanahub:master Mar 1, 2024
15 checks passed
@mdonadoni mdonadoni deleted the fix-pr-number-upgrade-shared-modules branch March 5, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants