dev: improve python-run-tests execution #756
Merged
+56
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 18.94% 18.99% +0.04%
==========================================
Files 26 26
Lines 2285 2290 +5
==========================================
+ Hits 433 435 +2
- Misses 1852 1855 +3
|
tiborsimko
force-pushed
the
reana-dev-run-python-tests-fixes
branch
5 times, most recently
from
184b552 to
5ff9253
Compare
|
How to test: $ cd ~/src/reana
$ workon reana
$ reana-dev git-checkout-pr --fetch \
-b reana 756 \
-b reana-db 208 \
-b reana-demo-cms-reco 30 \
-b reana-job-controller 411 \
-b reana-server 639 \
-b reana-workflow-controller 537 \
-b reana-workflow-engine-serial 188
$ pip install . --upgrade
$ PYTEST_ADDOPTS=tests/test_version.py reana-dev python-unit-tests -c ALL -k |
tiborsimko
force-pushed
the
reana-dev-run-python-tests-fixes
branch
2 times, most recently
from
28b4870 to
6ff27f4
Compare
mdonadoni
approved these changes
Nov 10, 2023
run-tests.sh
Outdated
Comment on lines
40
to
44
| if [ -n "${PYTESTARG-}" ]; then | ||
| pytest "$PYTESTARG" | ||
| else | ||
| python setup.py test | ||
| fi |
There was a problem hiding this comment.
I think that the changes to this file should not be needed
CHANGES.rst
Outdated
| -------------------------- | ||
|
|
||
| - Developers: | ||
| - Changes `python-run-tests` command to allow execution of selected pytests only by passing over `PYTESTARG` environment variable. |
There was a problem hiding this comment.
Suggested change
| - Changes `python-run-tests` command to allow execution of selected pytests only by passing over `PYTESTARG` environment variable. | |
| - Changes `python-run-tests` command to allow execution of selected pytests only by passing over `PYTEST_ADDOPTS` environment variable. |
tiborsimko
force-pushed
the
reana-dev-run-python-tests-fixes
branch
from
6ff27f4 to
a64bbea
Compare
Improves the `python-run-tests` command to create Python-3.8 based virtual environments to use the same version as container images. Updates `pip` before installing each component in order to speed up the dependency resolution for certain cluster components. Allows execution of selected pytests only by passing over `PYTEST_ADDOPTS` environment variable. Switches to using `run-tests.sh` to execute pytests in individual components which takes care of the DB setup at the source. Allows excluding certain Python components such as `-c CLUSTER --exclude-components r-j-controller` on macOS. Example: ``` $ PYTEST_ADDOPTS=tests/test_version.py reana-dev python-unit-tests -c ALL -k ``` Closes reanahub#755.
tiborsimko
force-pushed
the
reana-dev-run-python-tests-fixes
branch
from
a64bbea to
5a06eef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the
python-run-testscommand to create Python-3.8 based virtual environments to use the same version as container images.Updates
pipbefore installing each component in order to speed up the dependency resolution for certain cluster components.Allows execution of selected pytests only by passing over
PYTEST_ADDOPTSenvironment variable.Switches to using
run-tests.shto execute pytests in individual components which takes care of the DB setup at the source.Allows excluding certain Python components such as
-c CLUSTER --exclude-components r-j-controlleron macOS.Example:
Closes #755.