-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dask: refactor hard-coded values and rename dask cluster components #841
Open
Alputer opened this issue
Nov 4, 2024
· 0 comments
· May be fixed by reanahub/reana-workflow-controller#613 or reanahub/reana-commons#478
Open
dask: refactor hard-coded values and rename dask cluster components #841
Alputer opened this issue
Nov 4, 2024
· 0 comments
· May be fixed by reanahub/reana-workflow-controller#613 or reanahub/reana-commons#478
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, name of our Dask components
Dask cluster, Dask autoscaler, dashboard ingress and
are hardcoded in the code. For example the code snippet at the end of this paragraph is taken fromreana_workflow_controller.consumer.py
. We should probably have a function (e.gdef get_dask_cluster_name(worklow_id)
) in reana-commons to get the name for these components and make it configurable to cluster admins. Then we can use it where necessary. (reana-server, reana-workflow-controller
etc.). Besides, we may consider changing the names of Dask components since some of them are quite verbose and not easy to read. (e.g an ingress componentdask-dashboard-ingress-reana-run-dask-acd35ec0-3b81-4eda-b252-dd0d6b180869
)The text was updated successfully, but these errors were encountered: