Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dask): use centralized function for Dask component names #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alputer
Copy link
Member

@Alputer Alputer commented Nov 21, 2024

This PR refactors naming of Dask components which were previously hard-coded. Now, they are set centrally in a function that is placed in reana-commons.

Closes reanahub/reana#841

@Alputer Alputer self-assigned this Nov 21, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025
@Alputer Alputer force-pushed the dask-component-names branch from e549351 to c60af4f Compare January 22, 2025 13:16
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025
@Alputer Alputer force-pushed the dask-component-names branch from c60af4f to a0d961b Compare January 22, 2025 13:26
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025
@Alputer Alputer force-pushed the dask-component-names branch from a0d961b to f3f5e28 Compare January 22, 2025 14:55
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025
@Alputer Alputer force-pushed the dask-component-names branch from f3f5e28 to 7a2f7cc Compare January 22, 2025 16:13
@Alputer Alputer changed the title refactor(dask): remove hard-coded values for dask components refactor(dask): use centralized function for Dask component names Jan 22, 2025
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025
@Alputer Alputer force-pushed the dask-component-names branch from 7a2f7cc to 9b41f48 Compare January 22, 2025 16:53
@mdonadoni mdonadoni removed their request for review January 23, 2025 08:47
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from 9b41f48 to c9d2568 Compare January 23, 2025 09:00
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from c9d2568 to a296674 Compare January 23, 2025 09:05
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from a296674 to 068b1bd Compare January 23, 2025 09:12
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from 068b1bd to f2aaa0e Compare January 23, 2025 13:54
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from f2aaa0e to 29401bc Compare January 23, 2025 13:59
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from 29401bc to b2aa64b Compare January 23, 2025 14:05
@Alputer Alputer force-pushed the dask-component-names branch from b2aa64b to 20f3ff6 Compare January 23, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

dask: refactor hard-coded values and rename dask cluster components
1 participant