-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(dask): use centralized function for Dask component names #613
Open
Alputer
wants to merge
1
commit into
reanahub:master
Choose a base branch
from
Alputer:dask-component-names
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 22, 2025
Alputer
force-pushed
the
dask-component-names
branch
from
January 22, 2025 13:16
e549351
to
c60af4f
Compare
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 22, 2025
Alputer
force-pushed
the
dask-component-names
branch
from
January 22, 2025 13:26
c60af4f
to
a0d961b
Compare
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 22, 2025
Alputer
force-pushed
the
dask-component-names
branch
from
January 22, 2025 14:55
a0d961b
to
f3f5e28
Compare
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 22, 2025
Alputer
force-pushed
the
dask-component-names
branch
from
January 22, 2025 16:13
f3f5e28
to
7a2f7cc
Compare
Alputer
changed the title
refactor(dask): remove hard-coded values for dask components
refactor(dask): use centralized function for Dask component names
Jan 22, 2025
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 22, 2025
Alputer
force-pushed
the
dask-component-names
branch
from
January 22, 2025 16:53
7a2f7cc
to
9b41f48
Compare
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 23, 2025
Alputer
force-pushed
the
dask-component-names
branch
from
January 23, 2025 09:00
9b41f48
to
c9d2568
Compare
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 23, 2025
Alputer
force-pushed
the
dask-component-names
branch
from
January 23, 2025 09:05
c9d2568
to
a296674
Compare
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 23, 2025
Alputer
force-pushed
the
dask-component-names
branch
from
January 23, 2025 09:12
a296674
to
068b1bd
Compare
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 23, 2025
Alputer
force-pushed
the
dask-component-names
branch
from
January 23, 2025 13:54
068b1bd
to
f2aaa0e
Compare
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 23, 2025
Alputer
force-pushed
the
dask-component-names
branch
from
January 23, 2025 13:59
f2aaa0e
to
29401bc
Compare
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 23, 2025
Alputer
force-pushed
the
dask-component-names
branch
from
January 23, 2025 14:05
29401bc
to
b2aa64b
Compare
Alputer
force-pushed
the
dask-component-names
branch
from
January 23, 2025 14:59
b2aa64b
to
20f3ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors naming of Dask components which were previously hard-coded. Now, they are set centrally in a function that is placed in reana-commons.
Closes reanahub/reana#841