consumer: fix fetching of workflow engine logs when scheduling fails #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
approved these changes
Nov 17, 2023
CHANGES.rst
Outdated
| Version 0.9.2 (UNRELEASED) | ||
| -------------------------- | ||
|
|
||
| - Fixes job status consumer not to fail while fetching workflow engine logs of workflows that couldn't be scheduled. |
There was a problem hiding this comment.
What about:
- Fixes job status consumer exception while attempting to fetch workflow engine logs for workflows could not have been successfully scheduled.
mdonadoni
force-pushed
the
fix-engine-logs
branch
from
be8b046 to
3004b14
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #544 +/- ##
==========================================
+ Coverage 72.23% 72.34% +0.11%
==========================================
Files 15 15
Lines 1390 1385 -5
==========================================
- Hits 1004 1002 -2
+ Misses 386 383 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #543