rest: add include_command flag to get_workflow and get_workflow_status endpoints #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe-steduto
force-pushed
the
improve-include-progress
branch
from
85a0e13 to
5cfd227
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 72.23% 71.55% -0.68%
==========================================
Files 15 15
Lines 1390 1406 +16
==========================================
+ Hits 1004 1006 +2
- Misses 386 400 +14
|
giuseppe-steduto
force-pushed
the
improve-include-progress
branch
2 times, most recently
from
6181379 to
39bd12a
Compare
giuseppe-steduto
changed the title
giuseppe-steduto
force-pushed
the
improve-include-progress
branch
from
39bd12a to
eaaa5b8
Compare
mdonadoni
reviewed
Nov 21, 2023
Comment on lines
286
to
288
| include_last_command = json.loads( | ||
| request.args.get("include_last_command", "false").lower() | ||
| ) |
There was a problem hiding this comment.
What about validating and parsing parameters with use_args, as done in the other endpoint?
giuseppe-steduto
force-pushed
the
improve-include-progress
branch
2 times, most recently
from
5778363 to
8618891
Compare
mdonadoni
reviewed
Nov 23, 2023
CHANGES.rst
Outdated
| Version 0.9.2 (UNRELEASED) | ||
| -------------------------- | ||
|
|
||
| - Changes ``get_workflow_status``, ``get_workflows`` endpoints to add a ``include_command`` optional parameter to show info about currently executing command. |
There was a problem hiding this comment.
Suggested change
| - Changes ``get_workflow_status``, ``get_workflows`` endpoints to add a ``include_command`` optional parameter to show info about currently executing command. | |
| - Changes ``get_workflow_status``, ``get_workflows`` endpoints to add a ``include_last_command`` optional parameter to show info about currently executing command. |
requirements.txt
Outdated
| @@ -52,8 +52,8 @@ pyrsistent==0.19.3 # via jsonschema | |||
| python-dateutil==2.8.2 # via bravado, bravado-core, kubernetes | |||
| pytz==2023.3.post1 # via bravado-core | |||
| pyyaml==6.0.1 # via bravado, bravado-core, kubernetes, reana-commons, swagger-spec-validator | |||
| reana-commons[kubernetes]==0.9.4a2 # via reana-commons, reana-db, reana-workflow-controller (setup.py) | |||
| reana-db==0.9.2 # via reana-workflow-controller (setup.py) | |||
| reana-commons[kubernetes]==0.9.4a2 # via reana-commons, reana-db, reana-workflow-controller (setup.py) | |||
There was a problem hiding this comment.
Suggested change
| reana-commons[kubernetes]==0.9.4a2 # via reana-commons, reana-db, reana-workflow-controller (setup.py) | |
| reana-commons[kubernetes]==0.9.4a3 # via reana-commons, reana-db, reana-workflow-controller (setup.py) |
giuseppe-steduto
force-pushed
the
improve-include-progress
branch
from
8618891 to
9a6b388
Compare
|
No need to change API after performance improvements of reanahub/reana-db#213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installation: bump shared modules
rest: add include_command flag to get_workflow endpoints
Closes rest: optimise
include_progressfunctionality #486.