fix(ui): show jupyter badge only after the pod is running #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alputer
added a commit
to Alputer/reana-ui
that referenced
this pull request
Nov 18, 2024
Alputer
force-pushed
the
interactive-session-status-fix
branch
from
f534986 to
07ca1a7
Compare
Alputer
added a commit
to Alputer/reana-ui
that referenced
this pull request
Nov 20, 2024
Alputer
changed the title
tiborsimko
reviewed
Jan 15, 2025
| @@ -38,7 +38,7 @@ export default function WorkflowActionsPopup({ workflow, className }) { | |||
| const isDeleted = status === "deleted"; | |||
| const isDeletedUsingWorkspace = isDeleted && size.raw > 0; | |||
| const isRunning = status === "running"; | |||
| const isSessionOpen = sessionStatus === "created"; | |||
| const isSessionOpen = sessionStatus === "running"; | |||
There was a problem hiding this comment.
Works nicely 👍
BTW, now that we have a new design, we could amend the text "Click on the Jupyter logo to access it" to say something like "Click on the Jupyter notebook badge to access it."
There was a problem hiding this comment.
Cosmetics: for the commit log, please use capital letter for Jupyter:
fix(ui): show Jupyter badge only after notebook is running (#416)
07ca1a7 to
35c98b5
Compare
tiborsimko
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #408