-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 0.9.3 #372
release: 0.9.3 #372
Conversation
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "reana-ui", | |||
"version": "0.9.2", | |||
"version": "0.9.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this instead be 0.9.2.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have been numbering components independently in the past, and some bring new features, as it were, so I think we can go with independent versioning of components.
6448db2
to
cf439ad
Compare
CHANGES.rst
Outdated
-------------------------- | ||
|
||
- Adds metadata labels to Dockerfile. | ||
- Changes version of nginx Docker image from 1.19 to 1.25. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nginx with capital N?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it to NGINX (all uppercase), see for example the main page: https://www.nginx.com/
Dockerfile
Outdated
|
||
LABEL org.opencontainers.image.authors="[email protected]" | ||
LABEL org.opencontainers.image.created="2023-12-12" | ||
LABEL org.opencontainers.image.description="REANA UI" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about:
- "REANA reproducible analysis platform - web user interface component"
We could use the same description naming technique elsewhere, e.g. ...job controller component, ...Snakemake workflow engine component, etc.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "reana-ui", | |||
"version": "0.9.2", | |||
"version": "0.9.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have been numbering components independently in the past, and some bring new features, as it were, so I think we can go with independent versioning of components.
LABEL org.opencontainers.image.authors="[email protected]" | ||
LABEL org.opencontainers.image.created="2023-12-12" | ||
LABEL org.opencontainers.image.description="REANA UI" | ||
LABEL org.opencontainers.image.documentation="https://reana-ui.readthedocs.io/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since each paragraph in Dockerfile
is accompanied by a leading comment, you can precede the label setting section by:
# Set image labels
cf439ad
to
2414316
Compare
TODO