Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance for linking realm to local examples #6205

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

takameyer
Copy link
Contributor

@takameyer takameyer commented Oct 19, 2023

What, How & Why?

Our previous example was already updated to link to realm. We have since come up with even more examples and decided to keep them pure so that they are easier to use and also easier to update to newer version of React Native.

However, to debug using these examples requires some extra steps. I had tried to create a generic patch to do this, but it proved to be more trouble than it's worth. I have since created a guide to manually do this ourselves.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@coveralls-official
Copy link

Coverage Status

coverage: 85.397%. remained the same when pulling 0bfb33c on andrew/link-realm-guide into eca95b6 on main.

Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to put our users first at the expense of our development experience

Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good guide, thank you! Only got some minor suggestions.

contrib/debug-rn-examples.md Outdated Show resolved Hide resolved
contrib/debug-rn-examples.md Outdated Show resolved Hide resolved
contrib/debug-rn-examples.md Show resolved Hide resolved
contrib/debug-rn-examples.md Outdated Show resolved Hide resolved
contrib/debug-rn-examples.md Outdated Show resolved Hide resolved
contrib/debug-rn-examples.md Outdated Show resolved Hide resolved
contrib/debug-rn-examples.md Show resolved Hide resolved
contrib/debug-rn-examples.md Outdated Show resolved Hide resolved
@takameyer takameyer merged commit 33835a8 into main Oct 31, 2023
18 checks passed
@takameyer takameyer deleted the andrew/link-realm-guide branch October 31, 2023 14:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants