Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests to EmailPasswordClient #3472

Merged
merged 8 commits into from
Nov 10, 2023
Merged

Added tests to EmailPasswordClient #3472

merged 8 commits into from
Nov 10, 2023

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Nov 3, 2023

Fixes #3469

TODO

  • Tests (if applicable)

@papafe papafe requested a review from nirinchev November 3, 2023 14:09
@papafe papafe added the no-changelog Used to skip the changelog check label Nov 3, 2023
nirinchev
nirinchev approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me, but seems to never complete on CI. Can you rebase on latest main and re-run the tests. Once CI is green, I'm good with merging it.

@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 6823657397

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 80.65%
Totals Coverage Status
Change from base Build 6823600400: 0.4%
Covered Lines: 6374
Relevant Lines: 7781
💛 - Coveralls

@papafe papafe merged commit 0497a66 into main Nov 10, 2023
65 of 66 checks passed
@papafe papafe deleted the fp/test-email branch November 10, 2023 11:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

Assignees

@papafe papafe

Labels
no-changelog Used to skip the changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for the methods in EmailPasswordClient
2 participants
@papafe @nirinchev