Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Core 13.23.1, Prepare 0.4.0 release #103

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Update to Core 13.23.1, Prepare 0.4.0 release #103

merged 7 commits into from
Oct 19, 2023

Conversation

leemaguire
Copy link
Contributor

No description provided.

@leemaguire leemaguire changed the title Update to Core 13.23.1, Prepare 0.3.1 release Update to Core 13.23.1, Prepare 0.4.0 release Oct 17, 2023
@leemaguire leemaguire marked this pull request as ready for review October 18, 2023 10:25
fealebenpae
fealebenpae requested changes Oct 18, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakePresets.json Show resolved Hide resolved
src/cpprealm/app.cpp Outdated Show resolved Hide resolved
src/cpprealm/internal/network/network_transport.cpp Show resolved Hide resolved
fealebenpae
fealebenpae approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@fealebenpae fealebenpae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have two suggestions - remove the copy of GetGitRevisionDescription.cmake and use Core's directly, and put version_numbers.hpp in a more hidden location.

CMakeLists.txt Outdated Show resolved Hide resolved
src/version_numbers.hpp.in Outdated Show resolved Hide resolved
@leemaguire leemaguire merged commit 4edf6f6 into main Oct 19, 2023
@leemaguire leemaguire deleted the lm/core-13.23.1 branch October 19, 2023 12:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fealebenpae fealebenpae fealebenpae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leemaguire @fealebenpae