Bump file format version #7977
Merged
Bump file format version #7977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicola-cab
reviewed
Aug 12, 2024
| @@ -419,6 +419,7 @@ int Group::read_only_version_check(SlabAlloc& alloc, ref_type top_ref, const std | |||
| case 0: | |||
| file_format_ok = (top_ref == 0); | |||
| break; | |||
| case 24: | |||
There was a problem hiding this comment.
This is the version(s) we can open in read-only mode
There was a problem hiding this comment.
OK, got it, because v24 will be eventually rewritten in v25 after compression!
There was a problem hiding this comment.
Because we can read v24 without upgrade. If it is in read-only mode, we will not make any commits and therefore no compression will happen.
nicola-cab
approved these changes
Aug 12, 2024
| @@ -419,6 +419,7 @@ int Group::read_only_version_check(SlabAlloc& alloc, ref_type top_ref, const std | |||
| case 0: | |||
| file_format_ok = (top_ref == 0); | |||
| break; | |||
| case 24: | |||
There was a problem hiding this comment.
OK, got it, because v24 will be eventually rewritten in v25 after compression!
jedelbo
force-pushed
the
je/upgrade-file-format
branch
from
0862454 to
870d2a6
Compare
jedelbo
force-pushed
the
je/upgrade-file-format
branch
from
870d2a6 to
97549be
Compare
Pull Request Test Coverage Report for Build jorgen.edelbo_387Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
☑️ ToDos
bindgen/spec.yml, if public C++ API changed