Fix intermittent failure of the role change client reset tests

[michael-wb]

What, How & Why?

There is an intermittent failure in the "flx: role changes during client resets complete successfully" test where the sync client event hook callback is called at the same time the session is being torn down, leading to the weak_session.lock() returning a nullptr and the REQUIRE(session) assertion is failing. Example test failure

This change replaces the REQUIRE(session) with an early return from the event hook callback to prevent the test from failing in this case.

☑️ ToDos

• [ ] 📝 Changelog update
• [ ] 🚦 Tests (or not relevant)
• [ ] C-API, if public C++ API changed
• [ ] bindgen/spec.yml, if public C++ API changed

[coveralls-official]

Pull Request Test Coverage Report for Build michael.wilkersonbarker_1304

Details

• 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall first build on mwb/fix-role-change-failure at 91.043%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
test/object-store/sync/flx_role_change.cpp	1	3	33.33%

Totals
Change from base Build 2515:	91.0%
Covered Lines:	216426
Relevant Lines:	237719

---

💛 - Coveralls