Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2205 Remove unused changeset compaction code #7915

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

jbreams
Copy link
Contributor

@jbreams jbreams commented Jul 23, 2024

What, How & Why?

This has been hanging out in the codebase for years hidden away behind an #if 0 not doing anything. It's bit-rotted since the introduction of embedded objects.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link

Pull Request Test Coverage Report for Build jonathan.reams_3357

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 104 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.05%) to 91.079%

Files with Coverage Reduction New Missed Lines %
src/realm/dictionary.cpp 1 85.16%
src/realm/mixed.cpp 1 86.46%
src/realm/sync/network/websocket.cpp 1 71.79%
test/test_index_string.cpp 1 93.48%
src/realm/cluster.cpp 2 75.85%
src/realm/sync/instruction_replication.cpp 3 91.48%
src/realm/unicode.cpp 3 83.83%
src/realm/util/to_string.cpp 4 92.86%
src/realm/sync/noinst/client_impl_base.cpp 5 82.14%
src/realm/bplustree.cpp 6 72.55%
Totals Coverage Status
Change from base Build 2512: 0.05%
Covered Lines: 216350
Relevant Lines: 237541

💛 - Coveralls

Copy link
Collaborator

@danieltabacaru danieltabacaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jbreams jbreams merged commit 793b8b5 into master Jul 24, 2024
47 of 49 checks passed
@jbreams jbreams deleted the jbr/remove_compaction_stubs branch July 24, 2024 01:55
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants