RCORE-2204: Use accepting_clients key to check for initial sync completion in flx tests #7906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The initial sync progress endpoint has an additional key,
accepting_clients
, which in FLX is only set to true after the first initial sync completes. This is a more reliable way to check for initial sync completion than relying on individual namespaces. This PR updates the test helper to check that value instead for FLX apps.Additionally fixing a bug in the role change tests' API calls that is manifesting in the latest baas, but not the pinned baasaas version for some reason.
☑️ ToDos
bindgen/spec.yml
, if public C++ API changed