RCORE-2159 Make async_open_realm() return StatusWith<std::shared_ptr<Realm>> #7808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies a lot of test code and eliminates some cases where the Realm was being opened on a background thread, which is unsupported on linux.
Pull Request Test Coverage Report for Build thomas.goyne_417Details
💛 - Coveralls |
jbreams
reviewed
Jun 17, 2024
| }); | ||
| task->cancel(); // don't run the above notifier again on this session | ||
| finish(std::move(tsr), err); | ||
| auto sw = std::move(pf.future).get_no_throw(); |
There was a problem hiding this comment.
nit: i think this could be
return std::move(pf.future).then([&](ThreadSafeReference&& ref) {
return Realm::get_shared_realm(std::move(ref));
}).get_no_throw();
There was a problem hiding this comment.
No, that'd open the Realm on the wrong thread. Resolving the TSR needs to happen after the get() so that it happens on the main thread.
Future's API works well for passing around thread-unsafe objects but less so for thread-confined objects.
ironage
approved these changes
Jun 17, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies a lot of test code and seems to fix a case where we were opening a Realm on the wrong thread on Linux, although I'm not entirely sure how that was happening.
Fixes #7793.