RCORE-2155 Store FLX download progress in the Realm file #7780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/download-progress
branch
from
e77f16b to
71c0158
Compare
Pull Request Test Coverage Report for Build thomas.goyne_394Details
💛 - Coveralls |
tgoyne
force-pushed
the
tg/download-progress
branch
from
71c0158 to
7f03dd0
Compare
Pull Request Test Coverage Report for Build thomas.goyne_395Details
💛 - Coveralls |
tgoyne
force-pushed
the
tg/download-progress
branch
from
7f03dd0 to
5680af0
Compare
Pull Request Test Coverage Report for Build thomas.goyne_400Details
💛 - Coveralls |
tgoyne
force-pushed
the
tg/download-progress
branch
from
5680af0 to
caff9c2
Compare
Pull Request Test Coverage Report for Build thomas.goyne_412Details
💛 - Coveralls |
tgoyne
force-pushed
the
tg/download-progress
branch
from
caff9c2 to
6501c2c
Compare
Pull Request Test Coverage Report for Build thomas.goyne_415Details
💛 - Coveralls |
tgoyne
force-pushed
the
tg/download-progress
branch
from
6501c2c to
5931242
Compare
Pull Request Test Coverage Report for Build thomas.goyne_418Details
💛 - Coveralls |
Merged
This was referenced Jul 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiprocess sync needs this information to be available to non-sync-agent processes, which means storing it in the Realm file like the other progress information. For FLX we previously were always writing 0 to the downloadable_progress field in the history compartment, so we can reuse that field and don't have to make any schema changes. It's an integer field, so the double is stored as a fixed-point value with five digits of precision.
Pending bootstrap bytes similarly need to be read from the Realm file rather than passed directly to SessionWrapper, but that was already being persisted.
The separate notify_upload_progress() and notify_download_progress() functions and
only_if_new_uploadable_dataflag don't work in a multiprocess context. We need to determine what notifications should be sent based entirely on the previous and current state of the progress information, as that's all that secondary processes have access to. This turned out to not really be a problem.This should have no functional changes by itself, so no changes to the tests other than updating them to reflect downloadable_bytes no longer being a
uint64_t*.Fixes #7779.