Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable replication when writing to the pending bootstrap store" #7776

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

tgoyne
Copy link
Member

@tgoyne tgoyne commented Jun 5, 2024

This reverts commit afe0e0f.

DisableReplication actually disables replication on the DB, not the Transaction, so it's extremely unsafe to use. This was a very minor optimization so it's not worth doing if there's anything complicated about it.

This reverts commit afe0e0f.

DisableReplication actually disables replication on the DB, not the
Transaction, so it's extremely unsafe to use.
@tgoyne tgoyne self-assigned this Jun 5, 2024
@cla-bot cla-bot bot added the cla: yes label Jun 5, 2024
@tgoyne tgoyne added no-changelog no-jira-ticket Skip checking the PR title for Jira reference labels Jun 5, 2024
Copy link

coveralls-official bot commented Jun 5, 2024

Pull Request Test Coverage Report for Build thomas.goyne_392

Details

  • 27 of 31 (87.1%) changed or added relevant lines in 1 file are covered.
  • 62 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.002%) to 90.842%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/sync/noinst/pending_bootstrap_store.cpp 27 31 87.1%
Files with Coverage Reduction New Missed Lines %
src/realm/index_string.cpp 1 85.17%
src/realm/sync/network/websocket.cpp 1 71.79%
src/realm/util/file.cpp 1 78.73%
src/realm/uuid.cpp 1 98.48%
src/realm/sync/network/http.hpp 2 82.27%
src/realm/sync/noinst/protocol_codec.hpp 3 73.5%
src/realm/transaction.hpp 3 89.37%
test/test_thread.cpp 3 66.14%
src/realm/sync/noinst/server/server_history.cpp 5 63.44%
test/fuzz_group.cpp 6 46.57%
Totals Coverage Status
Change from base Build 2386: -0.002%
Covered Lines: 214764
Relevant Lines: 236414

💛 - Coveralls

@danieltabacaru danieltabacaru requested review from danieltabacaru and removed request for danieltabacaru June 5, 2024 06:22
@tgoyne tgoyne merged commit d8a2e45 into master Jun 5, 2024
45 of 49 checks passed
@tgoyne tgoyne deleted the tg/revert-broken-thing branch June 5, 2024 15:48
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants