-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check to verify the base commit build status in the release process #7775
Conversation
Pull Request Test Coverage Report for Build james.stone_556Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one small request
echo "CI checks for $GIT_HASH:" > $PR_BODY_FILE | ||
if [ "$GH_CHECK_STATE" = '"success"' ]; then | ||
echo " succeeded! :white_check_mark:" >> $PR_BODY_FILE | ||
else | ||
echo " failed! :x:" >> $PR_BODY_FILE | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this just gives a ✅ or ❌ if the sum total of the checks failed or not?
Maybe for reference, make the $GIT_HASH
value a link to the PR/commit used to to provide this status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am taking advantage that the text is rendered in the Github PR description, which expands the text of the ✅ or ❌ to render the emoji. In the same way, Git hashes in a Github PR automatically become links to the commit, from that it should be easy to poke around and find the failing check.
As discussed in the round table today, we'd like the automated process to check that the base branch is in a releasable state. This gives us confidence in the release, and allows us to skip evergreen checks on "changelog/version" only changes in the release process.
These script changes use the Github API to check the status of the commit being released. It writes the status in the "prepare" PR description along with a link to the build page. This is a non-blocking way of quickly seeing the state of the build without requiring that it pass to release. This allows us to manually inspect the build and make a release even if there are failing checks that have been deemed "sporadic failures" by the releaser.