Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XCode warning after 'notifications-fuzzer' directory was removed #7770

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

michael-wb
Copy link
Contributor

What, How & Why?

A bunch of old obsolete test files were removed as part of PR #7695, but an exclude entry for one of the items removed was still in the Package.swift xcode project file, which led to a warning when that file was opened in XCode. This PR removes that line that is no longer used to remove the warning.

☑️ ToDos

  • [ ] 📝 Changelog update
  • [ ] 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed
  • [ ] bindgen/spec.yml, if public C++ API changed

@michael-wb michael-wb added no-changelog no-jira-ticket Skip checking the PR title for Jira reference labels Jun 4, 2024
@michael-wb michael-wb self-assigned this Jun 4, 2024
@michael-wb michael-wb requested a review from tgoyne June 4, 2024 01:43
@cla-bot cla-bot bot added the cla: yes label Jun 4, 2024
Copy link

Pull Request Test Coverage Report for Build michael.wilkersonbarker_1142

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 192 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.09%) to 90.839%

Files with Coverage Reduction New Missed Lines %
test/test_dictionary.cpp 1 99.83%
test/test_index_string.cpp 1 93.48%
src/realm/cluster.cpp 2 75.6%
src/realm/table.hpp 2 91.84%
test/test_sync.cpp 2 92.89%
src/realm/util/assert.hpp 4 87.1%
test/fuzz_tester.hpp 4 57.32%
test/fuzz_group.cpp 24 46.89%
src/realm/sync/noinst/client_impl_base.cpp 43 82.83%
test/object-store/sync/flx_sync.cpp 53 98.27%
Totals Coverage Status
Change from base Build 2374: -0.09%
Covered Lines: 214620
Relevant Lines: 236263

💛 - Coveralls

@michael-wb michael-wb merged commit adddee6 into master Jun 4, 2024
48 checks passed
@michael-wb michael-wb deleted the mwb/fix-xcode-warning branch June 4, 2024 03:05
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants