Getting rid of some glue code #7748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicola-cab
approved these changes
May 29, 2024
src/realm/array_direct.hpp
Outdated
| result |= second_word << first_word_size; | ||
| // note: above shifts in zeroes below the bits we want | ||
| } | ||
| _bump(num_bits); | ||
| return result; | ||
| } | ||
| uint64_t get_with_unsafe_prefetch(size_t num_bits) |
There was a problem hiding this comment.
You are now fetching and moving the iterator in this method, probably we should rename it? Even though, I don't expect anybody to use the iterator. Although, it can be useful if we want to access the data directly.
src/realm/array_direct.hpp
Outdated
| @@ -710,11 +593,9 @@ size_t parallel_subword_find(VectorCompare vector_compare, const uint64_t* data, | |||
| while (total_bit_count_left >= fast_scan_limit) { | |||
| // unrolling 2x | |||
| const auto word0 = it.get_with_unsafe_prefetch(bit_count_pr_iteration); | |||
| it.bump(bit_count_pr_iteration); | |||
| const auto word1 = it.get_with_unsafe_prefetch(bit_count_pr_iteration); | |||
There was a problem hiding this comment.
I think renaming the method will make it clear that it has been moved by bit_count_pr_iterations bits.
Pull Request Test Coverage Report for Build jorgen.edelbo_277Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
☑️ ToDos
bindgen/spec.yml, if public C++ API changed