Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2134 GHA release script fixes #7727

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

ironage
Copy link
Contributor

@ironage ironage commented May 23, 2024

Related to #7566 and #7726.
Fixes based on the error reported in this run.

The error is

Rebasing commits made to branch 'master' on to base branch 'refs/heads/master'
  fatal: refusing to fetch into branch 'refs/heads/master' checked out at '/home/runner/work/realm-core/realm-core'

This is because I had set the base parameter unnecessarily, and the action wasn't smart enough to know that it should be a no-op. According to the docs:

There may be use cases where it makes sense to execute the workflow on a branch that is not the base of the pull request. In these cases, the base branch can be specified with the base action input. The action will attempt to rebase changes made during the workflow on to the actual base.

@ironage ironage requested review from jsflax and danieltabacaru May 23, 2024 22:16
@ironage ironage self-assigned this May 23, 2024
@cla-bot cla-bot bot added the cla: yes label May 23, 2024
@ironage ironage merged commit 4cfdcd6 into master May 23, 2024
13 of 14 checks passed
@ironage ironage deleted the js/gha-fix-prepare-release branch May 23, 2024 22:22
@fealebenpae fealebenpae mentioned this pull request May 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants