Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include '$set' in set of links #7721

Merged
merged 1 commit into from
May 28, 2024
Merged

Include '$set' in set of links #7721

merged 1 commit into from
May 28, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented May 23, 2024

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@cla-bot cla-bot bot added the cla: yes label May 23, 2024
@jedelbo jedelbo changed the title Include '' in set of links Include '$set' in set of links May 23, 2024
Copy link

Pull Request Test Coverage Report for Build jorgen.edelbo_265

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 51 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.007%) to 90.817%

Files with Coverage Reduction New Missed Lines %
src/realm/array_string.cpp 1 87.23%
src/realm/query_expression.hpp 1 93.84%
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/sync/network/http.hpp 1 82.27%
src/realm/util/serializer.cpp 1 90.43%
src/realm/object-store/shared_realm.cpp 2 91.89%
test/fuzz_group.cpp 3 48.33%
src/realm/sync/noinst/client_reset.cpp 4 91.93%
src/realm/bplustree.cpp 6 72.55%
src/realm/sync/noinst/server/server.cpp 15 73.6%
Totals Coverage Status
Change from base Build 2331: 0.007%
Covered Lines: 214619
Relevant Lines: 236321

💛 - Coveralls

@jedelbo jedelbo marked this pull request as ready for review May 23, 2024 14:06
@jedelbo jedelbo requested a review from nicola-cab May 23, 2024 14:06
@@ -136,7 +136,7 @@ void CollectionBaseImpl<LstBase>::to_json(std::ostream& out, JSONOutputMode outp
if (i > 0)
out << ",";
Mixed val = get_any(i);
if (val.is_type(type_TypedLink)) {
if (val.is_type(type_Link, type_TypedLink)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah.. Nice!

@jedelbo jedelbo merged commit 341c337 into master May 28, 2024
36 of 39 checks passed
@jedelbo jedelbo deleted the je/xjson-set branch May 28, 2024 10:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants